Crash identified in gmi_mp3.c in trunk rev 222

[jonof]

Hi

I've found a crash while getting easypmp working on my Macbook. Lines 330 and 343 of pmplib/lib/gmi/gmi_mp3.c are redundant and only cause a crash when the audio file fails to open.

It's perhaps also worth mentioning the other things I noticed: lib/pmp_portalplayer1/pmp_portalplayer1.c has a redundant compare_version() function, and lib/pmp/pmp_posix.c is out of sync with the win32 version's modifications.

Anyway, thanks for this program. I bought an E10 yesterday and was immediately able to use it thanks to pmplib and easypmp.

Jonathon

[nyaochi]

I've found a crash while getting easypmp working on my Macbook. Lines 330 and 343 of pmplib/lib/gmi/gmi_mp3.c are redundant and only cause a crash when the audio file fails to open.

I fixed this in the SVN trunk.

It's perhaps also worth mentioning the other things I noticed: lib/pmp_portalplayer1/pmp_portalplayer1.c has a redundant compare_version() function, and lib/pmp/pmp_posix.c is out of sync with the win32 version's modifications.

Yes, I'm aware that the SVN trunk is currently broken for POSIX environments. I'm changing PMPlib API drastically from 0.13 to the upcoming 0.14 release, and have to make sure that everything is alright on Win32 environment first, where I develop PMPlib daily.

Anyway, thanks for this program. I bought an E10 yesterday and was immediately able to use it thanks to pmplib and easypmp.

Thanks for the fix.